Merge pull request #124 from nhandler/110-optional-acl

Don't Specify an ACL by Default (Fixes #110)
drone-plugins · Sep 1, 2023 · ab94fa2 · ab94fa2
2 parents fe9d75b + 9070b33
commit ab94fa2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/main.go b/main.go
@@ -67,7 +67,6 @@ func main() {
 		cli.StringFlag{
 			Name:   "acl",
 			Usage:  "upload files with acl",
-			Value:  "private",
 			EnvVar: "PLUGIN_ACL",
 		},
 		cli.StringFlag{

diff --git a/plugin.go b/plugin.go
@@ -197,7 +197,6 @@ func (p *Plugin) Exec() error {
 			Body:   f,
 			Bucket: &(p.Bucket),
 			Key:    &target,
-			ACL:    &(p.Access),
 		}
 
 		if contentType != "" {
@@ -220,6 +219,10 @@ func (p *Plugin) Exec() error {
 			putObjectInput.StorageClass = &(p.StorageClass)
 		}
 
+		if p.Access != "" {
+			putObjectInput.ACL = &(p.Access)
+		}
+
 		_, err = client.PutObject(putObjectInput)
 
 		if err != nil {