Fix for Join Giotto Objects with Polygon information#338
Fix for Join Giotto Objects with Polygon information#338iqraAmin wants to merge 2 commits intodrieslab:devfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| spat_information_vector <- gpoly[] | ||
| spat_information_centroids <- centroids(gpoly) | ||
| spat_information_centroids <- tryCatch( | ||
| centroids(gpoly), |
Check warning
Code scanning / lintr
no visible global function definition for 'centroids' Warning
| cx[][["list_ID"]] <- gname | ||
| if (spat_unit %in% core_units) { | ||
| if (nrow(cx[]) == 0) { | ||
| stop(sprintf("Core spat_unit '%s' has 0 rows, object is invalid.", spat_unit)) |
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 102 characters. Note
| } | ||
|
|
||
| cx[][["list_ID"]] <- rep(gname, nrow(cx[])) | ||
| #cx[][["list_ID"]] <- gname |
Check notice
Code scanning / lintr
Remove commented code. Note
| centroids(gpoly), | ||
| error = function(e) NULL | ||
| ) | ||
| # spat_information_centroids <- centroids(gpoly) |
Check notice
Code scanning / lintr
Remove commented code. Note
1 participant
No description provided.