Prevent tipTip to activate when source element is not anymore attached#7
Open
amigrave wants to merge 1 commit intodrewwilson:masterfrom
Open
Prevent tipTip to activate when source element is not anymore attached#7amigrave wants to merge 1 commit intodrewwilson:masterfrom
amigrave wants to merge 1 commit intodrewwilson:masterfrom
Conversation
|
Hi, @amigrave |
|
Merge in: Floflis#8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eg: If you have a tipTip hovering on a button and the click event on the button will result in removing the button itself, the tipTip will be activated but the mouseLeave will never be triggered because the button element is not attached in the DOM anymore.
This is fixed by checking if the source element is still attached to the DOM before activating the tipTip