[mediator/client]fix issue plugin option can't use relative path.#43
Open
takeshi-sakurai wants to merge 3 commits into
Open
[mediator/client]fix issue plugin option can't use relative path.#43takeshi-sakurai wants to merge 3 commits into
takeshi-sakurai wants to merge 3 commits into
Conversation
dolow
reviewed
Jun 11, 2019
|
|
||
| for (let i = 0; i < args.plugins.length; i++) { | ||
| const plugin = args.plugins[i]; | ||
| if (isRelativePath(plugin)) { |
Contributor
There was a problem hiding this comment.
path.isAbsolute is more handy.
> path.isAbsolute('/aaaa/bbbb/cccc')
true
> path.isAbsolute('/aaaa/../cccc')
true
> path.isAbsolute('./aaaa/cccc')
false
Contributor
Author
There was a problem hiding this comment.
In this case, Is it make mistakes?
> path.isAbsolute('ModuleName')
false
It isn't relative path.
!absolute !== relative.
Contributor
There was a problem hiding this comment.
So there is another path variant.
- absolute
- relative
- resolved
In this case, this fix may be OK.
I'd like to forget about $NODE_PATH because it can be defined by user or user's environment, will you be supporting for this variable ?
Contributor
Author
There was a problem hiding this comment.
It basically worked correctly, as far as I tried.
The code below is worked correctly.
But, The following points need to be corrected.
Plugins have been removed by:
Contributor
Author
3dae03e to
94bfbba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sgmed can't accept relative path in plugin option.
I change plugin option relative path convert to absolute path on this pull request.