-
Notifications
You must be signed in to change notification settings - Fork 0
[DP-543] 픽픽픽 댓글/답글 조회 API 수정 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 익명회원 댓글 삭제 서비스 개발 및 테스트 코드 작성
# Conflicts: # src/main/java/com/dreamypatisiel/devdevdev/domain/service/pick/GuestPickCommentServiceV2.java # src/test/java/com/dreamypatisiel/devdevdev/domain/service/pick/GuestPickCommentServiceV2Test.java
# Conflicts: # src/test/java/com/dreamypatisiel/devdevdev/domain/service/pick/GuestPickCommentServiceV2Test.java
|
|
||
| // 댓글을 회원이 작성한 경우 | ||
| // 부모 댓글을 익명회원이 작성한 경우 | ||
| if (parentCreatedBy == null) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조건문이 조금 복잡(?)한 것 같은데 평탄화하면 어떨까요? 예를 들어 이런식으루...
boolean isRepliedByMember = repliedCreatedBy != null;
boolean isParentByMember = parentCreatedBy != null;
if (!isRepliedByMember && !isParentByMember) {
return createResponseForAnonymousReplyToAnonymous(...);
}
if (!isRepliedByMember) {
return createResponseForAnonymousReplyToMember(...);
}
if (!isParentByMember) {
return createResponseForMemberReplyToAnonymous(...);
}
return createResponseForMemberReplyToMember(...);
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 좋은 아이디어 감사합니다.
츄라츄라이 해보겠습니다! 👍
- PR 리뷰 반영
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🔗 참고할만한 자료(선택)
💬 리뷰 요구사항(선택)