-
Notifications
You must be signed in to change notification settings - Fork 0
[PRD-478] 내정보 내가 썼어요 댓글, 기술블로그 추천 기능 라이브 반영 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: 로그인유저 isAdmin 쿠키로 응답
…derByCommentCreatedAtDesc(..) - 내가 썼어요 댓글 쿼리 개발 및 테스트 코드 작성
- 내가 썼어요 댓글 쿼리 개발 및 테스트 코드 작성
- 내가 썼어요 댓글 조회 개발 및 테스트 코드 작성
[DP-452] fix: 일반회원 픽픽픽 작성시 자동 승인
- 내가 썼어요 댓글 조회 컨트롤러 개발 및 테스트 코드 작성
[DP-447] 기술블로그 추천 API
[DP-447] fix: GA 값 없을 경우 대응
- 내가 썼어요 댓글 조회 컨트롤러 개발 및 테스트 코드 작성 - 문서 작성
# Conflicts: # src/test/java/com/dreamypatisiel/devdevdev/domain/service/member/MemberServiceTest.java
- local 에서는 문제없이 동작하는데, gitHubAction 환경에서 정상적으로 동작이 안됨
- local 에서는 문제없이 동작하는데, gitHubAction 환경에서 정상적으로 동작이 안됨
[DP-449] 내가 썼어요 댓글 API 개발
[DP-464] bugfix: 회원/익명회원의 추천 여부 조회 메서드 -> 해당 추천의 추천자가 회원/익명회원인지 필터링하는 로직 추가
- action secret application-dev.yml mybatis 설정 추가 - Comment.xml findByMemberIdAndPickCommentIdAndTechCommentIdOrderByCommentCreatedAtDesc() alias 네이밍 수정 recommend_total_count-> comment_recommend_total_count
fix: 기술블로그 추천 API 응답에 총 추천수 추가
yu-so-young2
approved these changes
Jan 20, 2025
Member
yu-so-young2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DB 변경사항 반영
- Secret 변경사항 반영
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🔗 참고할만한 자료(선택)
💬 리뷰 요구사항(선택)