Skip to content

fix: 기술블로그 추천 API 응답에 총 추천수 추가 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssosee merged 1 commit into from
Jan 19, 2025
Merged

fix: 기술블로그 추천 API 응답에 총 추천수 추가 #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...amypatisiel/devdevdev/domain/service/techArticle/techArticle/GuestTechArticleService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public TechArticleRecommendResponse updateRecommend(Long techArticleId, String a
techArticle.decrementRecommendTotalCount();
techArticle.changePopularScore(techArticlePopularScorePolicy);

return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended());
return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended(), techArticle.getRecommendTotalCount().getCount());
}

// 추천 상태가 아니라면 추천
Expand All @@ -139,7 +139,7 @@ public TechArticleRecommendResponse updateRecommend(Long techArticleId, String a
techArticle.incrementRecommendTotalCount();
techArticle.changePopularScore(techArticlePopularScorePolicy);

return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended());
return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended(), techArticle.getRecommendTotalCount().getCount());
}

// 추천 생성
Expand All @@ -150,7 +150,7 @@ public TechArticleRecommendResponse updateRecommend(Long techArticleId, String a
techArticle.incrementRecommendTotalCount();
techArticle.changePopularScore(techArticlePopularScorePolicy);

return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended());
return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended(), techArticle.getRecommendTotalCount().getCount());
}

/**
Expand Down
6 changes: 3 additions & 3 deletions ...mypatisiel/devdevdev/domain/service/techArticle/techArticle/MemberTechArticleService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public TechArticleRecommendResponse updateRecommend(Long techArticleId, String a
techArticle.decrementRecommendTotalCount();
techArticle.changePopularScore(techArticlePopularScorePolicy);

return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended());
return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended(), techArticle.getRecommendTotalCount().getCount());
}

// 추천 상태가 아니라면 추천
Expand All @@ -160,7 +160,7 @@ public TechArticleRecommendResponse updateRecommend(Long techArticleId, String a
techArticle.incrementRecommendTotalCount();
techArticle.changePopularScore(techArticlePopularScorePolicy);

return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended());
return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended(), techArticle.getRecommendTotalCount().getCount());
}

// 추천 생성
Expand All @@ -172,7 +172,7 @@ public TechArticleRecommendResponse updateRecommend(Long techArticleId, String a

techArticleRecommendRepository.save(techArticleRecommend);

return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended());
return new TechArticleRecommendResponse(techArticle.getId(), techArticleRecommend.isRecommended(), techArticle.getRecommendTotalCount().getCount());
}

/**
Expand Down
4 changes: 3 additions & 1 deletion ...m/dreamypatisiel/devdevdev/web/dto/response/techArticle/TechArticleRecommendResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ public class TechArticleRecommendResponse {

public final Long techArticleId;
public final Boolean status;
public final Long recommendTotalCount;

public TechArticleRecommendResponse(Long techArticleId, Boolean status) {
public TechArticleRecommendResponse(Long techArticleId, Boolean status, Long recommendTotalCount) {
this.techArticleId = techArticleId;
this.status = status;
this.recommendTotalCount = recommendTotalCount;
}
}
1 change: 1 addition & 0 deletions .../com/dreamypatisiel/devdevdev/domain/service/techArticle/GuestTechArticleServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ void createTechArticleRecommend() {
.satisfies(response -> {
assertThat(response.getTechArticleId()).isEqualTo(techArticleId);
assertThat(response.getStatus()).isTrue();
assertThat(response.getRecommendTotalCount()).isEqualTo(recommendTotalCount.getCount() + 1);
});

TechArticle techArticle = techArticleRepository.findById(techArticleId).get();
Expand Down
1 change: 1 addition & 0 deletions ...com/dreamypatisiel/devdevdev/domain/service/techArticle/MemberTechArticleServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ void cancelTechArticleRecommend() {
.satisfies(response -> {
assertThat(response.getTechArticleId()).isEqualTo(techArticleId);
assertThat(response.getStatus()).isFalse();
assertThat(response.getRecommendTotalCount()).isEqualTo(recommendTotalCount.getCount() - 1);
});

TechArticle techArticle = techArticleRepository.findById(techArticleId).get();
Expand Down
4 changes: 3 additions & 1 deletion ...va/com/dreamypatisiel/devdevdev/web/controller/techArticle/TechArticleControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,9 @@ void updateRecommend() throws Exception {
.andExpect(jsonPath("$.data").isNotEmpty())
.andExpect(jsonPath("$.data").isMap())
.andExpect(jsonPath("$.data.techArticleId").isNumber())
.andExpect(jsonPath("$.data.status").isBoolean());
.andExpect(jsonPath("$.data.status").isBoolean())
.andExpect(jsonPath("$.data.recommendTotalCount").isNumber());

}

@Test
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/dreamypatisiel/devdevdev/web/docs/TechArticleControllerDocsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,8 @@ void updateRecommend() throws Exception {
fieldWithPath("data").type(JsonFieldType.OBJECT).description("응답 데이터"),

fieldWithPath("data.techArticleId").type(JsonFieldType.NUMBER).description("기술블로그 아이디"),
fieldWithPath("data.status").type(JsonFieldType.BOOLEAN).description("추천 상태")
fieldWithPath("data.status").type(JsonFieldType.BOOLEAN).description("추천 상태"),
fieldWithPath("data.recommendTotalCount").type(JsonFieldType.NUMBER).description("기술블로그 총 추천수")
)
));
}
Expand Down
Loading