Skip to content

[DP-464] bugfix: 회원/익명회원의 추천 여부 조회 메서드 -> 해당 추천의 추천자가 회원/익명회원인지 필터링하는 로직 추가 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssosee merged 1 commit into from
Jan 12, 2025
Merged

[DP-464] bugfix: 회원/익명회원의 추천 여부 조회 메서드 -> 해당 추천의 추천자가 회원/익명회원인지 필터링하는 로직 추가 #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/com/dreamypatisiel/devdevdev/domain/entity/TechArticleRecommend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,12 @@ public void registerRecommend() {
public boolean isRecommended() {
return this.status;
}

public boolean isAnonymousMemberNotNull() {
return this.anonymousMember != null;
}
public boolean isMemberNotNull() {
return this.member != null;
}

}
8 changes: 6 additions & 2 deletions src/main/java/com/dreamypatisiel/devdevdev/web/dto/util/TechArticleResponseUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ public static boolean isBookmarkedByMember(TechArticle techArticle, Member membe

public static boolean isRecommendedByMember(TechArticle techArticle, Member member) {
Optional<TechArticleRecommend> recommends = techArticle.getRecommends().stream()
.filter(recommend -> recommend.getMember().isEqualsId(member.getId()))
.filter(recommend ->
recommend.isMemberNotNull()
&& recommend.getMember().isEqualsId(member.getId()))
.findAny();

return recommends.map(TechArticleRecommend::isRecommended).orElse(false);
Expand All @@ -30,7 +32,9 @@ public static boolean isRecommendedByAnonymousMember(TechArticle techArticle, An
}

Optional<TechArticleRecommend> recommends = techArticle.getRecommends().stream()
.filter(recommend -> recommend.getAnonymousMember().isEqualAnonymousMemberId(anonymousMember.getId()))
.filter(recommend ->
recommend.isAnonymousMemberNotNull()
&& recommend.getAnonymousMember().isEqualAnonymousMemberId(anonymousMember.getId()))
.findAny();

return recommends.map(TechArticleRecommend::isRecommended).orElse(false);
Expand Down
Loading