Skip to content

Commit

Permalink
Separate release title and tag name
Browse files Browse the repository at this point in the history
In make-github-release.sh, so we can call the continuous release
something else than its tag name.
  • Loading branch information
askmeaboutlo0m committed Dec 4, 2024
1 parent 3b4f447 commit 33eb433
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TARGET_COMMIT: ${{ github.sha }}
RELEASE_DESCRIPTION_FILE: release-description
RELEASE_NAME: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || 'continuous alpha' }}
RELEASE_NAME: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || 'continuous' }}
RELEASE_TITLE: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || 'continuous alpha' }}
CLOBBER_EXISTING: ${{ !startsWith(github.ref, 'refs/tags/') }}
PRERELEASE: ${{ !startsWith(github.ref, 'refs/tags/') || contains(github.ref, '-') }}
run: |
Expand Down
8 changes: 7 additions & 1 deletion pkg/make-github-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,15 @@ else
prerelease_arg=
fi

if [[ -n $RELEASE_TITLE ]]; then
title="$RELEASE_TITLE"
else
title="$RELEASE_NAME"
fi

run_gh release create \
--target "$TARGET_COMMIT" \
--title "$RELEASE_NAME" \
--title "$title" \
--notes "$release_description" \
--draft \
$prerelease_arg \
Expand Down

0 comments on commit 33eb433

Please sign in to comment.