Fix incorrect "null" default value check in checkDefault #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bitshifter-9 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@1ilit can you check once |
1ilit
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in checkDefault where the code was checking typeof field instead of typeof field.default. Because of that, nullable fields with a default value of "null" were being incorrectly flagged as invalid.
What i was fixed
Updated the condition to correctly check typeof field.default, allowing "null" defaults to pass validation as intended.
Verification
I reproduced the issue using a standalone script (repro_bug_standalone.js):
Before the fix: "null" defaults were incorrectly flagged.
After the fix: The check works as expected.
This brings the behavior of checkDefault back in line with how nullable fields should be handled.
fixes #779