Quote and escape identifiers with spaces, umlauts, or non-ASCII characters in DBML export #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes an incompatibility between exporting and parsing: identifiers containing spaces or non-ASCII characters were exported without quotes, producing DBML that could not be parsed back.
Changes:
quoteIdentifier(name)
that quotes any identifier not matching^[A-Za-z_][A-Za-z0-9_]*$
.quoteIdentifier
to all table names, column names, index field names, enum values, and relationship endpoints during DBML export."
and\
inside quoted identifiers.Example Before:
Example After:
Why:
Ensures that exported DBML is always valid and re-parsable, avoiding round-trip errors when using non-ASCII or space-containing identifiers.
Tests:
fixes #581