Skip to content

feat: migrated to v10 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Note that in the above example, we're assuming the convention of each module con
Here's a basic story in its entirety:

```reason
open BsStorybook.Story;
open Storybook.Story;

let _module = [%bs.raw "module"];

Expand All @@ -70,7 +70,7 @@ Storybook uses a reference to the `module` global provided by webpack to facilit
If you'd prefer to use the newer [Component Story Format](https://storybook.js.org/docs/formats/component-story-format/), you can do that as well:

```reason
open BsStorybook;
open Storybook;

let default = CSF.make(~title="My CSF Story", ());

Expand Down
3 changes: 1 addition & 2 deletions bsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@
],
"reason": {
"react-jsx": 3
},
"refmt": 3
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"license": "MIT",
"devDependencies": {
"@rescript/react": "^0.10.3",
"rescript": "^9.1.4"
"rescript": "10"
},
"peerDependencies": {
"@rescript/react": "^0.10.3",
Expand Down
2 changes: 1 addition & 1 deletion src/knobs.res
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@val @module("@storybook/addon-knobs/react")
external withKnobs: Main.decorator = ""
external withKnobs: Main.decorator = "withKnobs"

@val @module("@storybook/addon-knobs/react")
external extText: (string, Js.null_undefined<string>) => string = "text"
Expand Down
2 changes: 1 addition & 1 deletion src/notes.res
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
type decoratedChapter = Main.chapter => Main.chapter

@module("@storybook/addon-notes")
external withNotes: string => decoratedChapter = ""
external withNotes: string => decoratedChapter = "withNotes"
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
resolved "https://registry.yarnpkg.com/@rescript/react/-/react-0.10.3.tgz#a2a8bed6b017940ec26c2154764b350f50348889"
integrity sha512-Lf9rzrR3bQPKJjOK3PBRa/B3xrJ7CqQ1HYr9VHPVxJidarIJJFZBhj0Dg1uZURX+Wg/xiP0PHFxXmdj2bK8Vxw==

rescript@^9.1.4:
version "9.1.4"
resolved "https://registry.yarnpkg.com/rescript/-/rescript-9.1.4.tgz#1eb126f98d6c16942c0bf0df67c050198e580515"
integrity sha512-aXANK4IqecJzdnDpJUsU6pxMViCR5ogAxzuqS0mOr8TloMnzAjJFu63fjD6LCkWrKAhlMkFFzQvVQYaAaVkFXw==
rescript@10:
version "10.0.0"
resolved "https://registry.yarnpkg.com/rescript/-/rescript-10.0.0.tgz#8460bc6f7d94bc580eac02d7c7efdf0a470916b8"
integrity sha512-LhNg/4+0j8NvoFeslgAeYLlzUwkq6kR6l6v8BnZ61VDTxopK2l96uT1lq5lv1aMxzMDynvE2qnX0zalre+6XxA==