Skip to content

Comments

Adjust types for WordCounts schema#339

Merged
cmil merged 1 commit intomainfrom
338-wordcount-types
Sep 16, 2025
Merged

Adjust types for WordCounts schema#339
cmil merged 1 commit intomainfrom
338-wordcount-types

Conversation

@cmil
Copy link
Member

@cmil cmil commented Sep 10, 2025

For high numbers the API issues the values for the individual word counts in scientific or E notation (see
https://en.wikipedia.org/wiki/Scientific_notation#E_notation). To make this work with pydracor-base we adjust the type to 'number'.

resolve #338

For high numbers the API issues the values for the individual word
counts in scientific or E notation (see
https://en.wikipedia.org/wiki/Scientific_notation#E_notation). To make
this work with pydracor-base we adjust the type to 'number'.

see #338
@cmil
Copy link
Member Author

cmil commented Sep 10, 2025

@hsluytergaethje This change is deployed to dev and staging. Does it fix the pydantic problem after regenerating the pydracor-base?

Copy link
Collaborator

@hsluytergaethje hsluytergaethje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the pydantic models now allow Float and Int which solves the issue.

@cmil cmil merged commit 64f33f8 into main Sep 16, 2025
1 check passed
@cmil cmil deleted the 338-wordcount-types branch September 16, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WordCount in the metrics supposed to be an integer but is a float for some corpora

2 participants