fix: adjustment for properties that don't match on type, or are forced as new

src/ReactiveUI.Avalonia.ViewToViewModelBindings/ReactiveUI.Avalonia.ViewToViewModelBindings.csproj

@@ -18,7 +18,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\Vetuviem.Avalonia.SourceGenerator\Vetuviem.Avalonia.SourceGenerator.csproj" OutputItemType="Analyzer" />
+    <ProjectReference Include="..\Vetuviem.Avalonia.SourceGenerator\Vetuviem.Avalonia.SourceGenerator.csproj" OutputItemType="Analyzer" PrivateAssets="all" ReferenceOutputAssembly="false" Private="false" />
     <ProjectReference Include="..\Vetuviem.Core\Vetuviem.Core.csproj" />
   </ItemGroup>
 

src/Vetuviem.SourceGenerator/Features/ControlBindingModels/ControlBindingModelPropertyGenerator.cs

@@ -32,7 +32,7 @@
             string? desiredCommandInterface,
             bool makeClassesPublic,
             bool includeObsoleteItems,
             string? platformCommandType)
         {
             if (namedTypeSymbol == null)
             {
@@ -148,16 +148,22 @@
             while (baseType != null)
             {
                 var nameMatches = baseType.GetMembers()
-                    .Where(x => x.Kind == SymbolKind.Property && x.Name.Equals(wantedName, StringComparison.Ordinal))
+                    .Where(x => x.Kind == SymbolKind.Property && x.Name.Equals(wantedName, StringComparison.Ordinal) && x.DeclaredAccessibility == Accessibility.Public)
                     .Cast<IPropertySymbol>()
                     .ToImmutableArray();
 
-                foreach (var nameMatch in nameMatches)
+                if (nameMatches.Length > 0)
                 {
-                    if (SymbolEqualityComparer.Default.Equals(nameMatch.Type, propertySymbol.Type))
+                    foreach (var nameMatch in nameMatches)
                     {
-                        return !propertySymbol.IsOverride;
+                        if (SymbolEqualityComparer.Default.Equals(nameMatch.Type, propertySymbol.Type))
+                        {
+                            return !propertySymbol.IsOverride;
+                        }
                     }
+
+                    // we didn't match by type, so assume it's a new implementation on a new type.
+                    return true;
                 }
 
                 baseType = baseType.BaseType;