Fix bug whereby events crossing year boundary could be hidden #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date maths is hard. :) If you have an event that finishes in an earlier month in a later year, it could be hidden by the previous logic. Feels like it should be possible to do this with moment().isBetween(), but it kind of gets a bit tricky because we don't check against a specific day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code only checked for month, not year, so an event spanning across the new year would potentially be hidden/shown when it shouldn't be.
Also, there's a problem whereby the splitting of the date string will result in some numbers being strings, so use parseInt() just in case (I was having a hard time with === compares!)