Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert back default type only named imports/exports sorting to "none" #666

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

dsherret
Copy link
Member

I think this should be off by default to the chance of merge conflicts. People rarely look at named imports/exports.

@dsherret dsherret changed the title fix: change default to not sort type only named imports/exports fix: default type only named imports/exports sorting to "none" Sep 17, 2024
@dsherret
Copy link
Member Author

Not going to do after discussion. Most of the type type only imports will be for interfaces and types so probably conflicts won't happen that often.

@dsherret dsherret closed this Sep 17, 2024
@dsherret dsherret reopened this Sep 18, 2024
@dsherret dsherret changed the title fix: default type only named imports/exports sorting to "none" fix: revert back default type only named imports/exports sorting to "none" Sep 18, 2024
@dsherret dsherret merged commit 1676dc7 into main Sep 18, 2024
5 checks passed
@dsherret dsherret deleted the fix_change_default_of_type_only_named_import_sorting branch September 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant