Ensure timeout is checked after each fetch position update #2668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Consumer.position()
I had a case whenself._update_fetch_positions
always resulted inTrue
andposition
was alwaysNone
. This hangs the loop for ~305 seconds, and it appears to me that the lineis never reached.
The root cause is probably how
timeout_ms
value is propagated and checked in the following methods, however I believe my change is still valid as the timeout check should work disregarding ofself._update_fetch_positions
value.