Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-239] use dropdown labels, update search listing pii, track number input #1323

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[SD-239] use dropdown labels, update search listing pii, track number input #1323

merged 2 commits into from
Sep 24, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 15, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-239

What I did

  • add RplFormNumber tracker so events are sent
  • set pii value for search listing filters
  • use labels for dataLayer events instead of the the value

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Sep 15, 2024
@lambry lambry added this to the 2.17.0 milestone Sep 15, 2024
@lambry lambry mentioned this pull request Sep 18, 2024
Merged
6 tasks
@dylankelly dylankelly merged commit 70628af into release/2.17.0 Sep 24, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feature/dropdown-dl branch September 24, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly