Refactor SQLite transactions, settings, and web reader - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Several files were at or near the repository's 500-line limit and combined unrelated responsibilities. SQLite transaction handling was also duplicated across stores, which allowed
PersonalVocabularyProfileStoreto return success without checking whetherCOMMITsucceeded.Impact
There should be no user-visible behavior change. The new boundaries make transaction failure handling consistent, reduce controller and JavaScript module size, and make future changes easier to test without exceeding the line limit.
Validation
./tests/run.sh— all 144 logic tests passed./scripts/check.sh --no-build— passed./scripts/check_ui_theme.sh --warnings-as-errors— passed./scripts/build_app.sh— debug arm64 build and signing passedgit diff --check— passed