global: More fixes for compiling without LDAP #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: W. Michael Petullo <[email protected]>
|
Can you please use 2.4.1 for both dovecot core and pigeonhole? Then use 61fe6bb and 4eddec2, and you need dovecot/pigeonhole@b37322a |
|
Also include 431e328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that Dovecot 2.4.0 would not build without ldap.h while trying to update OpenWrt's Dovecot package. I found commit 61fe6bb, but it appeared incomplete after I backported it. I think there are still some conditionals that need to be added to the build system.
This commit adds a few more conditionals. There is still a problem with
all-settings.cunconditionally including ldap.h, but I don't yet understandsettings-get.plenough to fix this.Additionally, it might be possible to simplify things, both with my changes and the existing build definitions.
Though incomplete, I hoped this patch would help make progress.