Removed what appears to be a redundant modification to the partition … #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which was causing the range to overrun.
|
The purpose of this range modification is to ensure that we only process the minimal amount of work needed on the thread which is adding tasks. Other threads may start to steal tasks, such that the pipe will be able to accept more tasks. I'd rather not remove this feature, so will investigate #60 first. |
|
I've pushed a fix to #60 - if that works for you I'll close this PR as I'd like to keep the range adjustment. |
|
Closing as the fix resolves your issue #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…which was causing the range to overrun.
See #60 for context. I don't know if this is the optimal fix though, just that it solves the issue for me.