Skip to content

Add DataObject tests #10781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Add DataObject tests #10781

merged 2 commits into from
Apr 21, 2025

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Apr 16, 2025

Description

The changes here aims at adding tests around ContainsText, ContainsAudio, and ContainsImage method of DataObject class. This is to validate that the contracts are not breached and avoid minor bugs after the merger of #10544. The changes also references to a task item mentioned in #10736.
Have moved the previous tests a bit to make sure they are in the desired region and hence the removals may look unnecessary, but these tests are still present in the same file.

Regression

None

Testing

Build pass, the tests are all green

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 10:03
@harshit7962 harshit7962 requested review from a team as code owners April 16, 2025 10:03
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.71918%. Comparing base (97aabac) to head (3f9aa97).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10781         +/-   ##
===================================================
+ Coverage   13.06870%   13.71918%   +0.65048%     
===================================================
  Files           3316        3317          +1     
  Lines         665468      665630        +162     
  Branches       74669       74674          +5     
===================================================
+ Hits           86968       91319       +4351     
+ Misses        576158      571617       -4541     
- Partials        2342        2694        +352     
Flag Coverage Δ
Debug 13.71918% <100.00000%> (+0.65047%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshit7962 harshit7962 merged commit 9c58920 into dotnet:main Apr 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants