Swap Dictionary<K, V> with HashSet<XamlMember>, avoid double lookup#10750
Open
h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Open
Swap Dictionary<K, V> with HashSet<XamlMember>, avoid double lookup#10750h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Dictionary<K, V> with HashSet<XamlMember>, avoid double lookup#10750h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
Bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
Bot
added
PR
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10750 +/- ##
===================================================
- Coverage 11.25778% 11.20973% -0.04805%
===================================================
Files 3315 3315
Lines 665229 665217 -12
Branches 74668 74667 -1
===================================================
- Hits 74890 74569 -321
- Misses 589035 589350 +315
+ Partials 1304 1298 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
XamlPropertySetwhich is just a wrappedDictionary<XamlMember, bool>withHashSet<XamlMember>for improved performance and decreased allocations. The conditions under which this was written do no longer apply.Also avoids double lookup on each addition.
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow