Avoid obsoletion warning suppression in ActiveXHost #10689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10689 +/- ##
===================================================
- Coverage 11.28308% 11.25335% -0.02974%
===================================================
Files 3353 3353
Lines 668062 668041 -21
Branches 74980 74980
===================================================
- Hits 75378 75177 -201
- Misses 591433 591616 +183
+ Partials 1251 1248 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
siagupta0202
approved these changes
Apr 23, 2025
|
@h3xds1nz Thank you for your contribution! |
|
@siagupta0202 Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids warning suppression for
ApartmentStateproperty by using the newer method instead. In the retrieval (get) context, checking for STA has no behavioral difference between those two, hence no reason to NOT use it.Also, this is the only place in WPF where the swap to the method hasn't been done yet.
Customer Impact
Cleaner codebase for developers, not using BCL obsoleted methods.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow