Fixes #13901. Properly displays PropertyGrid` color and cursor dropdowns when using Dark Mode #13950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ColorEditor.ColorUI` and `CursorEditor.CursorUI` use owner-draw ListBoxes with custom `OnDrawItem` handlers that use `DrawItemEventArgs.ForeColor` for text rendering. In Dark Mode, this property returns dark text color for selected items, creating poor contrast against the bright blue selection background. - Modified `ColorEditor.ColorUI.OnListDrawItem()` to use `SystemColors.ControlText` for selected item text in Dark Mode - Modified `CursorEditor.CursorUI.OnDrawItem()` to use `SystemColors.ControlText` for selected item text in Dark Mode Users can now properly read selected items in `PropertyGrid` color and cursor dropdowns when using Dark Mode. No Minimal Manual testing - 10.0.100-rc.1.25420.111
ricardobossan
added
waiting-review
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13950 +/- ##
===================================================
- Coverage 77.16116% 77.14958% -0.01158%
===================================================
Files 3273 3276 +3
Lines 644919 645126 +207
Branches 47694 47707 +13
===================================================
+ Hits 497627 497712 +85
- Misses 143607 143727 +120
- Partials 3685 3687 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13901
Root Cause
ColorEditor.ColorUIandCursorEditor.CursorUIuse owner-draw ListBoxes with customOnDrawItemhandlers that useDrawItemEventArgs.ForeColorfor text rendering. In Dark Mode, this property returns dark text color for selected items, creating poor contrast against the bright blue selection background.Proposed changes
ColorEditor.ColorUI.OnListDrawItem()to useSystemColors.ControlTextfor selected item text in Dark ModeCursorEditor.CursorUI.OnDrawItem()to useSystemColors.ControlTextfor selected item text in Dark ModeCustomer Impact
Users can now properly read selected items in
PropertyGridcolor and cursor dropdowns when using Dark Mode.Regression?
No
Risk
Minimal
Screenshots
Before
After
Test methodology
Manual testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow