Skip to content

Skip unstable ListView Tile tests and case ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Apr 11, 2025

Related #13288, #13291

Proposed changes

  • Skip the following unstable ListView tests on Windows x86
  1. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_FragmentNavigate_ReturnsNullAsync(columnCount: 1, subItemsCount: 0, width: 150, height: 150, direction: 3)
  2. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_FragmentNavigate_WorksExpectedAsync(columnCount: 2, subItemsCount: 2, width: 150, height: 150, itemIndex: 0, subItemIndex: 1, direction: 3)
  3. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChild_ReturnsExpected_For_BigSizeAsync
  4. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChild_ReturnsExpectedAsync
  5. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChild_ReturnsNullAsync(columnCount: 4, subItemsCount: 0, width: 150, height: 150)
  6. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildAsync(columnCount: 4, subItemsCount: 1)
  7. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildCount_ReturnsExpectedAsync(columnCount: 4, subItemsCount: 3, width: 150, height: 150, expected: 3)
  8. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildIndex_ForDifferentSize_ReturnsExpectedAsync(columnCount: 4, subItemsCount: 1, width: 150, height: 150, expected1: -1, expected2: 1)
  9. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildIndex_ReturnsExpected_For_BigSizeAsync
  10. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildIndex_ReturnsExpected_SubItemsMoreThanColumnsAsync
  11. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildIndex_ReturnsExpectedAsync
  12. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_SubItem_FragmentNavigate_Child_ReturnsNullAsync
  13. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_SubItem_FragmentNavigate_NextSibling_ReturnsExpectedAsync
  14. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_SubItem_FragmentNavigate_Sibling_ReturnsNull_For_SmallSizeAsync
  15. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_SubItem_FragmentNavigate_Sibling_ReturnsNullAsync(columnCount: 4, subItemsCount: 1)
  16. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_SubItem_HitTest_ReturnExpectedAsync
  17. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_ColumnProperty_ReturnsMinusOneAsync
  18. System.Windows.Forms.UITests.ListViewTests.ListView_Tile_GetChildIndex_ReturnsMinusOne_For_Single_ColumnAsync
  19. ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/test/integration/UIIntegrationTests/ListViewTests.cs:114

  • [nitpick] Consider adding a TODO comment to track re-enabling these tests once the underlying issues are resolved.
[ActiveIssue("https://github.com/dotnet/winforms/issues/13291")]

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.32509%. Comparing base (1d61434) to head (b2f1ff5).
Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1d61434) and HEAD (b2f1ff5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1d61434) HEAD (b2f1ff5)
Debug 3 2
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13294          +/-   ##
====================================================
- Coverage   62.19645%   40.32509%   -21.87136%     
====================================================
  Files           1556        1018         -538     
  Lines         159366       96404       -62962     
  Branches       14854       13450        -1404     
====================================================
- Hits           99120       38875       -60245     
+ Misses         59495       57107        -2388     
+ Partials         751         422         -329     
Flag Coverage Δ
Debug 40.32509% <ø> (-21.87136%) ⬇️
integration 11.30059% <ø> (ø)
production 40.32509% <ø> (-0.01141%) ⬇️
test ?
unit 37.68101% <ø> (-0.01141%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik
Copy link
Member

@LeafShi1 - how many failures had you seen? Could you please investigate what the cause could be?

@LeafShi1
Copy link
Member Author

@LeafShi1 - how many failures had you seen? Could you please investigate what the cause could be?

ListView Tile related tests have failed 3 times in the past two weeks, the first failure was in this PR #13284
image

Everything has returned to normal in the past few days, I will follow up on these issues further

@dotnet-policy-service dotnet-policy-service bot added untriaged The team needs to look at this issue in the next triage and removed 📭 waiting-author-feedback labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure untriaged The team needs to look at this issue in the next triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants