Add code coverage for ToolStripContainerActionList#13256
Merged
Tanya-Solyanik merged 9 commits intodotnet:mainfrom Apr 16, 2025
Merged
Add code coverage for ToolStripContainerActionList#13256Tanya-Solyanik merged 9 commits intodotnet:mainfrom
Tanya-Solyanik merged 9 commits intodotnet:mainfrom
Conversation
Olina-Zhang
reviewed
Apr 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13256 +/- ##
====================================================
- Coverage 75.97321% 62.53133% -13.44188%
====================================================
Files 3265 1560 -1705
Lines 643286 159616 -483670
Branches 47431 14900 -32531
====================================================
- Hits 488725 99810 -388915
+ Misses 150991 59039 -91952
+ Partials 3570 767 -2803
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs:163
- [nitpick] The expected display name 'Dock Fill in Form' in this test seems inconsistent with the 'Dock in Form' string used in another test. Consider aligning the naming conventions between tests for clarity and consistency.
displayNames.Should().ContainSingle(name => name == "Dock Fill in Form");
Tanya-Solyanik
added
the
waiting-author-feedback
LeafShi1
reviewed
Apr 9, 2025
Syareel-Sukeri
added
waiting-review
…/Forms/Design/ToolStripContainerActionListTests.cs
…/Forms/Design/ToolStripContainerActionListTests.cs
…/Forms/Design/ToolStripContainerActionListTests.cs
Tanya-Solyanik
previously approved these changes
Apr 16, 2025
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Thank you, looks good, please keep lines under the 120 chars limit.
Tanya-Solyanik
added
ready-to-merge
Member
|
src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\ToolStripContainerActionListTests.cs(160,50): error SA1028: (NETCORE_ENGINEERING_TELEMETRY=Build) Code should not contain trailing whitespace |
Tanya-Solyanik
approved these changes
Apr 16, 2025
dotnet-policy-service
Bot
removed
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow