Trigger Characters missing in formatAfterKeyStroke

[akshita31]

Issue : #1591

To ensure proper bracket styling, entering '{' should trigger a format request. Also '\n' is one of the expected characters for triggering the format request. It was present in omnisharp-roslyn but not present as trigger character on the vscode side.

Please review : @DustinCampbell @TheRealPiotrP @rchande

[akshita31]

omnisharp-roslyn side : OmniSharp/omnisharp-roslyn#1042

[DustinCampbell]

@TheRealPiotrP: Should there be a label for cross-cutting changes like these that depend on a new OmniSharp build?

[gregg-miskelly]

Should this be merged now?

[akshita31]

This is blocked on : OmniSharp/omnisharp-roslyn#1042 and microsoft/vscode#40235

[TheRealPiotrP]

@akshita31 still blocked?

[DustinCampbell]

Is there anything blocking this?

[akshita31]

@DustinCampbell I haven't looked into this one for some time. Will take it up now.

[akshita31]

I am not sure what is the correct approach to deal with this.

[Ashen-Vaults]

Any updates on when this will be merged?

[Kira-Pilot]

Any news on this?

[gabrieldechichi]

Any Updates on this? It shows it's been waiting to be merged for a while now.

[JoeRobich]

To take this PR we would need an updated O# change to support opening brace and new line as triggers. Going to close this until there is a change on the O# side.