Set PackageProjectUrl #8854
Open
Set PackageProjectUrl #8854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids showing dotnet/dotnet when building in the VMR repo
mmitche
requested review from
ViktorHofer and
a team
and removed request for
a team
mmitche
commented
Mar 21, 2025
| @@ -7,6 +7,7 @@ | |||
| <Product>Microsoft .NET</Product> | |||
| <Copyright>$(CopyrightNetFoundation)</Copyright> | |||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | |||
| <PackageProjectUrl>https://github.com/dotnet/templating</PackageProjectUrl> | |||
There was a problem hiding this comment.
@marcpopMSFT What do you think here? Should the package project url point to dotnet/dotnet or dotnet/templating?
There was a problem hiding this comment.
The alternative is to point to https://dot.net which runtime sets: https://github.com/dotnet/runtime/blob/97a8af91e8d005216624528fe7ef501a6c95f25c/Directory.Build.props#L231
There was a problem hiding this comment.
I don't think it matters a lot, but I agree it should either point to dotnet/templating or use the generic dot.net.
|
Resolves dotnet/source-build#4966 |
akoeplinger
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids showing dotnet/dotnet when building in the VMR repo