Add support for C++ libs into sourcelink #605
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.IO; | ||
| using System.Collections.Generic; | ||
| using Microsoft.Build.Framework; | ||
| using Microsoft.Build.Utilities; | ||
| using System; | ||
|
|
||
| namespace Microsoft.SourceLink.Common | ||
| { | ||
| public sealed class FindAdditionalSourceLinkFiles : Task | ||
| { | ||
| /// <summary> | ||
| /// The name/path of the sourcelink file that we will merge into. | ||
| /// </summary> | ||
| [Required, NotNull] | ||
| public string? SourceLinkFile { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Collection of all the library directories that will be searched for lib files. | ||
| /// </summary> | ||
| [Required, NotNull] | ||
| public string[]? AdditionalLibraryDirectories { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Collection of all the libs that we will link to. | ||
| /// </summary> | ||
| [Required, NotNull] | ||
| public string[]? AdditionalDependencies { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Collection of solution referenced import libraries. | ||
| /// </summary> | ||
| [Required, NotNull] | ||
| public string[]? ImportLibraries { get; set; } | ||
|
|
||
| [Output] | ||
| public string[]? AllSourceLinkFiles { get; set; } | ||
|
|
||
| public override bool Execute() | ||
| { | ||
| List<string> allSourceLinkFiles = new List<string>(); | ||
| allSourceLinkFiles.Add(SourceLinkFile); | ||
|
|
||
| try | ||
| { | ||
| //// Throughout we expect that the sourcelink files for a lib is alongside | ||
| //// the lib with the extension sourcelink.json instead of lib. | ||
|
|
||
| // For import libraries we always have the full path to the lib. This shouldn't be needed since | ||
| // the path will be common to the dll/exe project. We have this in case there are out of tree | ||
| // references to library projects. | ||
| foreach (var importLib in ImportLibraries) | ||
| { | ||
| string sourceLinkName = Path.ChangeExtension(importLib, "sourcelink.json"); | ||
| if (File.Exists(sourceLinkName)) | ||
| { | ||
| Log.LogMessage("Found additional sourcelink file '{0}'", sourceLinkName); | ||
| allSourceLinkFiles.Add(sourceLinkName); | ||
| } | ||
| } | ||
|
|
||
| // Try and find sourcelink files for each lib | ||
| foreach (var dependency in AdditionalDependencies) | ||
| { | ||
| string sourceLinkName = Path.ChangeExtension(dependency, "sourcelink.json"); | ||
| if (Path.IsPathRooted(dependency)) | ||
| { | ||
| // If the lib path is rooted just look for the sourcelink file with the appropriate extension | ||
| // on that path. | ||
| if (File.Exists(sourceLinkName)) | ||
| { | ||
| Log.LogMessage("Found additional sourcelink file '{0}'", sourceLinkName); | ||
| allSourceLinkFiles.Add(sourceLinkName); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| // Not-rooted, perform link like scanning of the lib directories to find the full lib path | ||
| // and then look for the sourcelink file alongside the lib with the appropriate extension. | ||
| foreach (var libDir in AdditionalLibraryDirectories) | ||
| { | ||
| string potentialPath = Path.Combine(libDir, sourceLinkName); | ||
| if (File.Exists(potentialPath)) | ||
| { | ||
| Log.LogMessage("Found additional sourcelink file '{0}'", potentialPath); | ||
| allSourceLinkFiles.Add(potentialPath); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| AllSourceLinkFiles = allSourceLinkFiles.ToArray(); | ||
| return true; | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| Log.LogError("Failed to find sourcelink files for libs with dll/exe sourcelink file - {0}", ex.Message); | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo:
fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed