Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 27, 2025

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

…251126.6

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25576.6
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25576.6
@DonnaChen888
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

dotnet-maestro bot and others added 8 commits November 28, 2025 02:01
…251127.6

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25577.6
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25577.6
…251128.9

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25578.9
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25578.9
…251128.12

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25578.12
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25578.12
…251201.5

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25601.5
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25601.5
…251202.3

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25602.3
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25602.3
DonnaChen888 and others added 3 commits December 4, 2025 09:15
…251203.1

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25603.1
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25603.1
MiYanni and others added 2 commits December 4, 2025 17:52
…251204.3

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25604.3
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25604.3
DonnaChen888 and others added 2 commits December 5, 2025 11:15
…251205.6

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25605.6
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25605.6
…251209.4

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25609.4
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25609.4
…251210.8

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25610.8
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25610.8
DonnaChen888 and others added 3 commits December 12, 2025 09:25
…251211.7

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25611.7
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25611.7
@dsplaisted
Copy link
Member

@nagilson @MiYanni We should probably revert f7ede10, as the test that was disabled should be fixed with #52134, and we don't want to accidentally leave the test disabled

@nagilson
Copy link
Member

Great point, thanks

@nagilson
Copy link
Member

If the versions [] issue is fixed, then we expect a new test fx issue to resolve (regex issue) as in the other testfx branches.

…251212.5

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25612.5
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25612.5
dotnet-maestro bot and others added 2 commits December 14, 2025 02:01
…251212.7

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25612.7
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25612.7
@joeloff
Copy link
Member

joeloff commented Dec 15, 2025

I think we may need to update some of the tests, but still investigating...

》CSC : warning MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) [C:\h\w\A9410983\t\dotnetSdkTests\2cwojbxj.idv\6fcc3159-12e0---FBCD72DF\TestProject\TestProject.csproj]
 》C:\h\w\A9410983\t\dotnetSdkTests\2cwojbxj.idv\6fcc3159-12e0---FBCD72DF\TestProject\Test1.cs(17,4): warning MSTEST0025: Use 'Assert.Fail' instead of an always-failing 'Assert.AreEqual' assert (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0025) [C:\h\w\A9410983\t\dotnetSdkTests\2cwojbxj.idv\6fcc3159-12e0---FBCD72DF\TestProject\TestProject.csproj]
 》C:\h\w\A9410983\t\dotnetSdkTests\2cwojbxj.idv\6fcc3159-12e0---FBCD72DF\TestProject\Test1.cs(11,4): warning MSTEST0032: Review or remove the assertion as its condition is known to be always true (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0032) [C:\h\w\A9410983\t\dotnetSdkTests\2cwojbxj.idv\6fcc3159-12e0---FBCD72DF\TestProject\TestProject.csproj]

@joeloff
Copy link
Member

joeloff commented Dec 15, 2025

So looks like the test locally is failing with "exit code 5", but the regex is looking for exit code 8.

The test outputs are different. TestProject/OtherTestProject have the expected failures, but AnotherTestProject is not producing the expected results.

DonnaChen888 and others added 5 commits December 16, 2025 09:57
…251215.8

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25615.8
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25615.8
@joeloff
Copy link
Member

joeloff commented Dec 16, 2025

@dotnet/dotnet-testing-admin Could you please take a look at my test fix? Previously, the test relied on inducing 3 different error codes, but by injecting incorrect arguments, all three test projects fail and exit with code 5. By fixing the arguments, the first two tests still fail with different exit codes (2 and 8) and that still passes the validation check to ensure that the dotnet test command exits with code 1 (generic failure).

Below is what the testcase output log shows

Executing 'dotnet test --minimum-expected-tests 2 --configuration Release':
》Running tests from C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\AnotherTestProject\bin\Release\net10.0\AnotherTestProject.dll (net10.0|x64)
》Running tests from C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\OtherTestProject\bin\Release\net10.0\OtherTestProject.dll (net10.0|x64)
》Running tests from C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\TestProject\bin\Release\net10.0\TestProject.dll (net10.0|x64)
》skipped Test2
》  OK skipped!
》  from C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\OtherTestProject\bin\Release\net10.0\OtherTestProject.dll (net10.0|x64)
》C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\AnotherTestProject\bin\Release\net10.0\AnotherTestProject.dll (net10.0|x64) passed (113ms)
》failed Test3
》  not OK
》  from C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\OtherTestProject\bin\Release\net10.0\OtherTestProject.dll (net10.0|x64)
》  not OK
》C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\OtherTestProject\bin\Release\net10.0\OtherTestProject.dll (net10.0|x64) failed with 1 error(s) (117ms)
》Exit code: 2
》C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\TestProject\bin\Release\net10.0\TestProject.dll (net10.0|x64) Zero tests ran (108ms)
》Exit code: 8
》
》Test run summary: Failed!
》  C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\OtherTestProject\bin\Release\net10.0\OtherTestProject.dll (net10.0|x64) failed with 1 error(s) (117ms)
》  C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\TestProject\bin\Release\net10.0\TestProject.dll (net10.0|x64) Zero tests ran (108ms)
》  C:\git\sdk\artifacts\tmp\Debug\testing\5f845284-878b---A12CDD09\AnotherTestProject\bin\Release\net10.0\AnotherTestProject.dll (net10.0|x64) passed (113ms)
》
》  error: 1
》
》  total: 4
》  failed: 1
》  succeeded: 2
》  skipped: 1
》  duration: 521ms

dotnet-maestro bot and others added 2 commits December 17, 2025 02:01
…251216.5

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25575.3 -> To Version 2.1.0-preview.25616.5
MSTest From Version 4.1.0-preview.25575.3 -> To Version 4.1.0-preview.25616.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants