dnup code review #50988

dsplaisted · 2025-09-24T21:46:33Z

We're not planning to merge this to main yet, but we want to start reviewing the code.

Copilot prompt: Implement the GetConfiguredInstallType method in #file:'DotnetInstaler.cs' . This method should look in the PATH and resolve "dotnet" or "dotnet.exe", depending on the current OS. If it is not found, the return value should be SdkInstallType.None. If it is found in Program Files, the install type should be SdkInstallType.Admin. If it is found in another folder, the install type should be SdkInsntallType.User. However, the method should also check the value of DOTNET_ROOT environment variable. For a user install, DOTNET_ROOT should be set to the folder where the dotnet executable is found. For an admin install, DOTNET_ROOT should not be set, but if it is set to the install path under program files, that is OK. If the DOTNET_ROOT value doesn't match the install location, the method should return SdkInstallType.Inconsistent.

Copilot prompt: In #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaler.GetConfiguredInstallType':301-2793 , use #method:'Microsoft.DotNet.Cli.Utils.EnvironmentProvider.GetCommandPath':2399-2843 to search for dotnet on the path.

Copilot prompts: Create a class to represent the contents of a global.json file, and create a corresponding JsonSerializerContext type. Can you refer to https://learn.microsoft.com/en-us/dotnet/core/tools/global-json to update the schema you are using for the global.json file? AllowPrerelease should be a booleann, and instead of Path there should be a Paths property which is an array of strings.

Copilot prompts: Implement #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.GetDefaultDotnetInstallPath':2814-2986 . It look for a global.json file starting in the specified directory and walking up the directory chain. If it finds one, it should deserialize its contents using System.Text.Json APIs and #class:'Microsoft.DotNet.Tools.Bootstrapper.GlobalJsonContentsJsonContext':413-650 , and use that for the return value. Sorry, I meant to ask you to implement #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.GetGlobalJsonInfo':4307-4411 instead of #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.GetDefaultDotnetInstallPath':2839-2947 . Can you revert your changes and then implement #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.GetGlobalJsonInfo':4307-4411 using the instructions I previously provided?

Copilot prompts: Can you remove the try catch block around reading the global.json file in #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.GetGlobalJsonInfo':3019-4216 ? Also remove the convenience properties you added to GlobalJsonInfo for now. OK, go ahead and add those convencience properties back.

Copilot prompt: Implement the #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.ConfigureInstallType':4479-4606 method. If the install type is user, remove any other folder with dotnet in it from the PATH and add the dotnetRoot to the PATH. Also set the DOTNET_ROOT environment variable to dotnetRoot. If the install type is Admin, unset DOTNET_ROOT, and add dotnetRoot to the path (removing any other dotnet folder from the path). If the install type is None, unset DOTNET_ROOT and remove any dotnet folder from the path. For any other install type, throw an ArgumentException.

Copilot prompt: In #method:'Microsoft.DotNet.Tools.Bootstrapper.DotnetInstaller.ConfigureInstallType':4481-6459 what I meant by removing a folder from the path if it has dotnet in it was that you should check the contents of each folder and if it is a dotnet installation folder then it should be removed from the path. A simple way to check if it's a dotnet installation folder is if it has a dotnet executable in it.

I renamed the InstallType as the Runtime installs would similarly hold the same properties.

We should try to use our default libraries when possible instead of shelling out to the tar process. There were some issues with the library with null terminators, but they have been resolved in .net 10 preview 4.

the objects should be public to be json-ifiable

github-actions · 2025-09-24T21:46:41Z

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

Copilot

Pull Request Overview

This PR adds the initial code for "dnup", a new .NET bootstrapper tool designed to facilitate installing and managing .NET SDKs. It introduces a comprehensive .NET installer system with archive-based installation, manifest management, version resolution, and command-line interface.

Adds a new dnup installer tool with command-line SDK installation functionality
Implements archive-based extraction and installation system with progress reporting
Provides version channel resolution (e.g., "latest", "lts", "preview", feature bands)

Reviewed Changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/Installer/dnup/dnup.csproj`	New project file for dnup bootstrapper tool targeting net10.0 with AOT publishing
`src/Installer/dnup/Program.cs`	Main entry point for dnup application with command parsing
`src/Installer/dnup/DotnetVersion.cs`	Comprehensive .NET version parsing and manipulation logic
`src/Installer/dnup/ReleaseManifest.cs`	Release manifest handling for downloading and resolving .NET versions
`src/Installer/dnup/Commands/Sdk/Install/SdkInstallCommand.cs`	SDK installation command implementation with interactive prompts
`test/dnup.Tests/*.cs`	Unit tests for version parsing, manifest resolution, and installation logic

Copilot · 2025-09-24T21:48:03Z

src/Installer/dnup/ReleaseManifest.cs

+            // Handle Preview channel - get the latest preview version
+            var productIndex = ProductCollection.GetAsync().GetAwaiter().GetResult();
+            return GetLatestPreviewVersion(productIndex, mode);
+        }        // Parse the channel string into components


There's a missing line break between the closing brace and the comment. This creates a syntax error. The comment should be on a separate line or removed if it's stale.

Suggested change

} // Parse the channel string into components

}

// Parse the channel string into components

Copilot · 2025-09-24T21:48:04Z

src/Installer/dnup/ReleaseManifest.cs

+        }
+
+        return null; // No preview versions found
+    }    /// <summary>


There's a missing line break between the closing brace and the XML documentation comment. This creates a formatting issue that may cause problems.

Suggested change

} /// <summary>

}

/// <summary>

Copilot · 2025-09-24T21:48:04Z

test/dnup.Tests/ReleaseManifestTests.cs

+            var manifest = new ReleaseManifest();
+
+            var version = manifest.GetLatestVersionForChannel("9.0.1xx", InstallMode.SDK);
+            Console.WriteLine($"Version found: {version ?? "null"}");


[nitpick] Using Console.WriteLine in unit tests is not recommended. Consider using the test framework's output mechanisms or removing these debug statements.

Copilot · 2025-09-24T21:48:04Z

test/dnup.Tests/ReleaseManifestTests.cs

+            var manifest = new ReleaseManifest();
+            var version = manifest.GetLatestVersionForChannel("lts", InstallMode.SDK);
+
+            Console.WriteLine($"LTS Version found: {version ?? "null"}");


[nitpick] Using Console.WriteLine in unit tests is not recommended. Consider using the test framework's output mechanisms or removing these debug statements.

Copilot · 2025-09-24T21:48:04Z

test/dnup.Tests/ReleaseManifestTests.cs

+            var manifest = new ReleaseManifest();
+            var version = manifest.GetLatestVersionForChannel("sts", InstallMode.SDK);
+
+            Console.WriteLine($"STS Version found: {version ?? "null"}");


[nitpick] Using Console.WriteLine in unit tests is not recommended. Consider using the test framework's output mechanisms or removing these debug statements.

Copilot · 2025-09-24T21:48:05Z

test/dnup.Tests/ReleaseManifestTests.cs

+            var manifest = new ReleaseManifest();
+            var version = manifest.GetLatestVersionForChannel("preview", InstallMode.SDK);
+
+            Console.WriteLine($"Preview Version found: {version ?? "null"}");


[nitpick] Using Console.WriteLine in unit tests is not recommended. Consider using the test framework's output mechanisms or removing these debug statements.

dsplaisted and others added 30 commits August 14, 2025 22:57

Initial dotnet sdk install CLI definition

1350261

Add SDK update command

413e698

Rename VersionOrChannel argument to just Channel

61e48aa

Implement part of UI for install command

51ffe3d

Add more installer UI

5834280

UI improvements and add dnup shims for demo

1bf3e57

More install experience updates

225a5cf

Add SdkInstallCommand code to dnup

9f6340c

Wire up sdk install command for dnup

eaffa94

Add string resources to dnup project

4394b54

Add initial installer interfaces for dnup

37c42aa

Add initial installer interfaces for dnup (#50379)

9f372f7

Add dnup solution filter and add Environment provider to project

0b39a6e

Fix typo

c78f198

Rename class and more

cd575a2

Implement GetConfiguredInstallType and GetGlobalJsonInfo (#50408)

dd90109

Add more installer methods

bd28700

Add calls to new methods

8e2bdf9

Add more methods to installer interface (#50475)

3e29ba6

Add boilerplate types and interfaces to do installs

c0075f8

I renamed the InstallType as the Runtime installs would similarly hold the same properties.

Add base version class

060a91b

Add dotnetVersion class for version parsing

a09f30f

Add dotnetVersion class for version parsing (#50492)

a918d06

nagilson added 26 commits August 26, 2025 16:51

Prepare some install logic from dnup (#50504)

065a05d

Migrate to .NET Archive Libraries

e4b7e42

We should try to use our default libraries when possible instead of shelling out to the tar process. There were some issues with the library with null terminators, but they have been resolved in .net 10 preview 4.

Implement Extraction Logic

2f458c9

Implement DNUP Extraction logic (#50626)

52c1191

Implement manifest parsing and vscode setting folder for build button

93bc61f

Implement manifest parsing (#50642)

a213377

Installing .NET works e2e

00ff09d

Installing .NET works e2e with dnup (#50645)

2640948

Show progress correctly

3fcf146

fix end message

0a668b4

find available SDKs

df9fde0

Working Progress indicators (#50647)

2bd4154

Add update cadence method for manifest tracking

716e6c2

the objects should be public to be json-ifiable

Add implementation of manifest methods

1c465ef

Extract + Install combined to one step

2da2e77

Fix json aot serialization

b35c6d8

find existing versions + parse channels

7dfe03e

find existing versions

e4f4fd0

Add tests for version parsing.

dca4da2

Correctly parse 9.0.1xx, and 9, and 9.0

87eea7d

Fix version parsing

1121152

add lts sts schannel support. fix project.

f65bc4e

add preview support.

681ab98

Add dnup manifest + channel parsing (#50665)

f7e399c

Fix LTS STS Parsing

70a828f

Fix LTS STS Parsing (#50688)

7535e7c

Copilot AI review requested due to automatic review settings September 24, 2025 21:46

github-actions bot added the Area-Infrastructure label Sep 24, 2025

Copilot AI reviewed Sep 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dnup code review #50988

dnup code review #50988

Uh oh!

dsplaisted commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Uh oh!

	} // Parse the channel string into components
	}
	// Parse the channel string into components

dnup code review #50988

Are you sure you want to change the base?

dnup code review #50988

Uh oh!

Conversation

dsplaisted commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!