Add file-based program API for use by debugger #48905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a file-based program API for debuggers by introducing a new run-api command and supporting changes in project building and command handling. Key changes include:
- A new test (Api_RunCommand) for the run-api command.
- Modifications to VirtualProjectBuildingCommand and RunCommand to support custom artifact paths and launch profile adjustments.
- Updates to RunApiCommand, CommandFactoryUsingResolver, and Command to integrate the new API functionality.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Added test for verifying the run-api command output. |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Integrated a CustomArtifactsPath property into the artifacts path resolution. |
| src/Cli/dotnet/Commands/Run/RunCommand.cs | Made launch profile and internal methods nullable/internal to support the new API. |
| src/Cli/dotnet/Commands/Run/Api/RunApiCommand.cs | Introduced new RunApiInput/Output types for the file-based API functionality. |
| src/Cli/dotnet/CommandFactory/CommandFactoryUsingResolver.cs | Updated command creation to support custom environment variables. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Command.cs | Enhanced the constructor and environment variable handling to track custom environment values. |
MiYanni
approved these changes
May 12, 2025
Co-authored-by: Copilot <[email protected]>
|
@dotnet/run-file for reviews, thanks |
jaredpar
approved these changes
Jun 11, 2025
chsienki
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #48749.
Debug functionality will need to know the target executable path to launch. This API provides that info.