Skip to content

Bring back PublishDotnetWatch #48793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tmat
Copy link
Member

@tmat tmat commented May 1, 2025

Revert parts of #47767, which broke inner dev loop for dotnet-watch tests.
dotnet-watch project build needs to deploy to redist directory, so that any updates to dotnet-watch are picked up by dotnet-watch tests.

@tmat tmat marked this pull request as ready for review May 1, 2025 23:20
@Copilot Copilot AI review requested due to automatic review settings May 1, 2025 23:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • src/BuiltInTools/dotnet-watch/dotnet-watch.csproj: Language not supported
  • src/Layout/redist/targets/Directory.Build.targets: Language not supported
  • src/Layout/redist/targets/GenerateLayout.targets: Language not supported
  • src/Layout/redist/targets/PublishDotnetWatch.targets: Language not supported

@tmat
Copy link
Member Author

tmat commented May 1, 2025

@ViktorHofer

@ViktorHofer
Copy link
Member

Redist.csproj composes the SDK's sdk folder by pulling artifacts from all of the repo local sdk tools, not via a push model. Why is dotnet-watch different here?

To me this sounds like a test project setup issue. I.e. see dotnet.Tests.csproj:

<!-- Use layout folder for the output folder, to support in-process tests which expect to be running
on a valid layout. -->
<OutputPath>$(ArtifactsBinDir)redist\$(Configuration)</OutputPath>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>

That directly pushes into sdk's testhost folder so that the bits are always fresh. I don't see that happening in dotnet-watch.Tests.csproj: https://github.com/dotnet/sdk/blob/7601b9cae2f49701609df537fe81ae73425109ed/test/dotnet-watch.Tests/dotnet-watch.Tests.csproj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants