Skip to content

[DO NOT MERGE] Switch to using darc vmr forwardflow #48351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Switch to using darc vmr forwardflow #48351

wants to merge 2 commits into from
+48 −188

Conversation

premun
Copy link
Member

@premun premun commented Apr 10, 2025

@Copilot Copilot bot review requested due to automatic review settings April 10, 2025 13:17
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 10, 2025
@premun premun marked this pull request as draft April 10, 2025 13:17
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/vmr-sync.sh: Language not supported

@premun premun added Area-Infrastructure DO NOT MERGE and removed Area-Infrastructure untriaged Request triage from a team member labels Apr 10, 2025
@premun premun force-pushed the prvysoky/forwardflow branch from 03a9f42 to 2ec938f Compare April 10, 2025 13:30
@build-analysis build-analysis bot mentioned this pull request Apr 10, 2025
Open
3 tasks
@premun premun force-pushed the prvysoky/forwardflow branch from 4b61994 to 452ac66 Compare April 11, 2025 11:41
@premun
Copy link
Member Author

premun commented Apr 11, 2025

@NikolaMilosavljevic I made a small fix in darc, bumped it here and now it's synchronizing using the darc vmr forwardflow command. But for your experiments with moving the templates, I'd suggest:

  • Leaving the files changed in this PR more or less intact (keep using darc vmr update basically)
  • Pick a different repo than dotnet/sdk to test the templates as the other repos don't have SB patches and additional mappings
  • Focus on figuring out how to pull in the vmr-* YAML correctly and run the build

After you get this part, I'd do the switch of the command and we will also have to wait for the flat flow switch probably (and for first backflows into every repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area-Infrastructure DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@premun