Skip to content

[main] Update dependencies from dotnet/fsharp #47880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 25, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/fsharp

…325.5

Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler
 From Version 9.0.300-beta.25160.5 -> To Version 9.0.300-beta.25175.5
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Mar 25, 2025
@carlossanlop
Copy link
Member

Waiting for dotnet/fsharp#18329 to flow into here.

Once that flows, this needs to get merged to unblock #47853.

…326.2

Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler
 From Version 9.0.300-beta.25160.5 -> To Version 9.0.300-beta.25176.2
…326.3

Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler
 From Version 9.0.300-beta.25160.5 -> To Version 9.0.300-beta.25176.3
@carlossanlop carlossanlop removed the Blocked Issue is blocked on an external dependency label Mar 26, 2025
@carlossanlop
Copy link
Member

Finally, the maintenance-packages update flowed into here: dotnet/fsharp#18329

@carlossanlop
Copy link
Member

New CI failure, it's related: System.ValueTuple 4.6.1 is not compatible with netstandard1.6 :

  Determining projects to restore...
/datadisks/disk1/work/A7190940/p/d/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(187,5): warning NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details. [/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj]
/datadisks/disk1/work/A7190940/p/d/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(187,5): warning NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details. [/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj]
/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj : error NU1202: Package System.ValueTuple 4.6.1 is not compatible with netstandard1.6 (.NETStandard,Version=v1.6). Package System.ValueTuple 4.6.1 supports:
/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj : error NU1202:   - net462 (.NETFramework,Version=v4.6.2)
/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj : error NU1202:   - net47 (.NETFramework,Version=v4.7)
/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj : error NU1202:   - net471 (.NETFramework,Version=v4.7.1)
/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj : error NU1202:   - netcoreapp2.0 (.NETCoreApp,Version=v2.0)
/datadisks/disk1/work/A7190940/t/dotnetSdkTests.HYv0WP21/ImplicitConfi---B1714E0A/TestLibrary/TestLibrary.fsproj : error NU1202:   - netstandard2.0 (.NETStandard,Version=v2.0)

cc @ericstj @ViktorHofer @KevinRansom

@carlossanlop
Copy link
Member

@ericstj
Copy link
Member

ericstj commented Mar 26, 2025

New package doesn't support netstandard1.6. You'd either need to make it so that test doesn't use the new package, or change the test to target netstandard2.0.

@carlossanlop
Copy link
Member

Thanks. Makes sense. I'll fix it here directly.

@ericstj
Copy link
Member

ericstj commented Mar 26, 2025

If you go the latter route, I think the things to change would be:

<TargetFramework>netstandard1.6</TargetFramework>

and every place in here that mentions netstandard1
public class GivenThatWeWantToBuildALibraryWithFSharp : SdkTest

…target netstandard2.0 as it's the minimum supported by that assembly.
@carlossanlop
Copy link
Member

I have updated the tests that I saw failing in my machine. Given that running all Microsoft.NET.Build.Tests locally takes around 15 minutes, and some tests don't behave well locally (they expect a version without a commit hash, which only shows up in the local runs), I might have missed some. But I was still able to fix a bunch of VB, C# and F# tests showing errors with System.ValueTuple. So if we see more failures in the CI, I'll fix them.

@dotnet-maestro dotnet-maestro bot merged commit 164c6c3 into main Mar 27, 2025
43 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-1e70e08d-b28d-4696-98b2-9be333bb88a1 branch March 27, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants