Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticWebAssets] Make all the properties in StaticWebAssetEndpoint lazy #47833

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Mar 24, 2025

  • Avoid accessing the properties until needed.
  • Reuse the original Task Item if it wasn't modified.
  • Avoid deserializing expensive properties unless needed.

Another ~200ms cut

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.00

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.03

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.01

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.09

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:05.96

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.04

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.06

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.28

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.05

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.21

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Mar 24, 2025
@javiercn javiercn force-pushed the javiercn/reuse-original-task-item-for-unmodified-assets-and-endpoints branch from 35a62ba to 619fdcd Compare March 24, 2025 14:18
@javiercn javiercn force-pushed the javiercn/reuse-original-task-item-for-unmodified-assets-and-endpoints branch 2 times, most recently from 1bcdfd2 to f8ebdc5 Compare March 25, 2025 19:08
@javiercn javiercn force-pushed the javiercn/reuse-original-task-item-for-unmodified-assets-and-endpoints branch from ceb7eae to 8d2f7ea Compare March 26, 2025 10:31
@javiercn javiercn force-pushed the javiercn/reuse-original-task-item-for-unmodified-assets-and-endpoints branch from 9bbca84 to ed38386 Compare March 27, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant