Skip to content

fix: Rename astoria samples with underscore instead of space #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

fix: Rename astoria samples with underscore instead of space #810

merged 1 commit into from
Apr 11, 2019

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 11, 2019 •
edited by rpetrusha
Loading

Related to dotnet/docs#11784
Related to dotnet/dotnet-api-docs#2291

Some files were deleted because they are gitignored

@nschonni
fix: Rename astoria samples with underscore instead of space
8ebe65c 
Related to dotnet/docs#11784
Some files were deleted because they are gitignored
@nschonni nschonni mentioned this pull request Apr 11, 2019
Merged
@BillWagner BillWagner mentioned this pull request Apr 11, 2019
Merged
@rpetrusha
Copy link

@nschonni, the renamed samples are also used in the dotnet/dotnet-api-docs repo. Before this PR is merged, there will also have to be a PR to rename the file paths there as well. I've created a gist that lists the files in the dotnet/dotnet-api-docs repo using these examples.

@nschonni nschonni mentioned this pull request Apr 11, 2019
Merged
@nschonni
Copy link
Contributor Author

@rpetrusha I did a find and replace and PR'd the dotnet-api-docs now

rpetrusha
rpetrusha approved these changes Apr 11, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nschonni. I'll merge this PR, then rebuild the two related PRs in dotnet/docs and dotnet/dotnet-api-docs.

@rpetrusha rpetrusha merged commit f6c9de2 into dotnet:master Apr 11, 2019
@nschonni nschonni deleted the underscore-astoria branch April 11, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nschonni @rpetrusha