[NativeAOT-LLVM] Add support for <NativeLib>Static</NativeLib>
#3195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
added
the
area-NativeAOT-LLVM
Refactor the targets and sink more WASM specifics into the WASM-specific targets.
SingleAccretion
force-pushed
the
StaticLib-Main
branch
from
351a5ac to
6253f18
Compare
|
@dotnet/nativeaot-llvm |
|
wanderful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sink more WASM specifics into the WASM-specific targets.
Initially I also wanted to combine all runtime implementation libraries into one big archive with
llvm-ar qL, but after thinking about it a bit more, it doesn't seem like it would move the needle that much in terms of presenting a clean public contract, since you still need to be very careful with both the linking order, and the arguments. So "copyNativeLib=Sharedlink command line and be prepared to alter it once in a while" it still is.