Use cgroup to calculate available memory #89682
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #49317
It seems that on
GCToOSInterface::GetMemoryStatus
theGetPhysicalMemoryLimit
works by checking first cgroup limits, butGetAvailablePhysicalMemory
uses/proc/meminfo
that in a containerized environment it will report the available memory of the worker and not of the pod.This has as a result the check
if (total > available)
will be in a lot of cases false (when the worker available memory is more than the container's limit) and to report back to gc inconsistent data.This is more a trigger for a discussion than a ready PR, since I have no experience in c++, neither in gc. We stumble upon this problem in the organization I am working, and this is an attempt to solve a gc related performance degradation.