-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test merging baseservices/threading #83143
Conversation
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsThis another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
|
Before:
Now:
|
There are only 3 baseservices/threading tests on issues.target but none of those has change |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThis another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
|
Related issue #71732 |
c015c18
to
8a253c0
Compare
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks Brian!
This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.