Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test merging baseservices/threading #83143

Merged
merged 8 commits into from
Mar 14, 2023

Conversation

BrianBohe
Copy link
Member

This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.

@ghost
Copy link

ghost commented Mar 8, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.

Author: BrianBohe
Assignees: BrianBohe
Labels:

area-System.Reflection.Metadata

Milestone: -

@BrianBohe
Copy link
Member Author

Before:

Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
    126.661 |   180 |    180 |      0 |       0 | baseservices.threading.XUnitWrapper.dll
----------------------------------------------------------------------------
    126.661 |   180 |    180 |      0 |       0 | (total)

Now:

Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
    222.114 |    85 |     85 |      0 |       0 | baseservices.threading.threading_group1
    152.050 |    95 |     95 |      0 |       0 | baseservices.threading.threading_group2
----------------------------------------------------------------------------
    374.164 |   180 |    180 |      0 |       0 | (total)

@BrianBohe
Copy link
Member Author

There are only 3 baseservices/threading tests on issues.target but none of those has change

@BrianBohe BrianBohe requested a review from markples March 8, 2023 17:20
@BrianBohe BrianBohe added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 9, 2023
@ghost
Copy link

ghost commented Mar 9, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.

Author: BrianBohe
Assignees: BrianBohe
Labels:

area-System.Reflection.Metadata, area-CodeGen-coreclr

Milestone: -

@BrianBohe
Copy link
Member Author

Related issue #71732

@BrianBohe
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BrianBohe BrianBohe requested a review from trylek March 9, 2023 21:57
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks Brian!

@BrianBohe BrianBohe added the test-enhancement Improvements of test source code label Mar 10, 2023
@BrianBohe BrianBohe merged commit a78f9bd into dotnet:main Mar 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI area-System.Reflection.Metadata test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants