Fix ILLink.Tasks output path in source-only builds - #132484
Merged
akoeplinger merged 1 commit intoAug 18, 2026
Merged
Conversation
NetFrameworkToolCurrent is blanked in source-only builds, so the empty TargetFramework of the outer build matched the netframework condition and the outer OutputPath/IntermediateOutputPath wrongly got a "netframework" suffix. Guard the conditions on NetFrameworkToolCurrent being non-empty, matching what the mono task projects already do. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50cbbd7b-5246-4157-959c-0f92990d8f73
dotnet-policy-service
Bot
added
the
linkable-framework
github-actions
Bot
added
the
area-Tools-ILLink
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ILLink.Tasks output/intermediate path rewriting so that source-only outer builds no longer incorrectly append a netframework\ suffix when $(NetFrameworkToolCurrent) is blank (matching the guard already applied in #132402).
Changes:
- Guard the
netframeworkOutputPathrewrite on$(NetFrameworkToolCurrent)being non-empty. - Guard the
netframeworkIntermediateOutputPathrewrite on$(NetFrameworkToolCurrent)being non-empty.
sbomer
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ILLink.Tasksmulti-targets$(NetCoreAppToolCurrent);$(NetFrameworkToolCurrent)andrewrites
OutputPath/IntermediateOutputPathintonet\/netframework\subfoldersso the build output mirrors the NuGet package layout.
In a source-only build (
/p:DotNetBuildSourceOnly=true),Directory.Build.propsblanksNetFrameworkToolCurrentso that only the .NET Core TFM is built. But thenetframeworkconditions compare against$(TargetFramework), which is also emptyduring the outer (TFM-dispatching) build.
'' == ''evaluates to true, so the outerbuild's paths incorrectly picked up a
netframeworksuffix:artifacts/bin/ILLink.Tasks/Debug/artifacts/bin/ILLink.Tasks/Debug/netframework/artifacts/bin/ILLink.Tasks/Debug/net11.0.../Debug/net/net472.../Debug/netframework/Guard both conditions on
NetFrameworkToolCurrentbeing non-empty. This matches the fixalready applied to the mono task projects in #132402.
This is latent today — no consumer reads the outer
$(OutputPath)(they all hardcode thenetsubfolder) — but it's a trap for anything that adds such a consumer later, e.g. aGetFilesToPackage-style target.Note
This PR description was generated by GitHub Copilot.