Improve StringBuilder.ToString() exception message for inconsistent state - #132483
Open
aw0lid wants to merge 1 commit into
Open
Improve StringBuilder.ToString() exception message for inconsistent state#132483aw0lid wants to merge 1 commit into
aw0lid wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
aw0lid
marked this pull request as ready for review
August 18, 2026 20:23
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
bartonjs
reviewed
Aug 18, 2026
aw0lid
force-pushed
the
fix/stringbuilder-tostring-exception-message
branch
from
August 18, 2026 23:38
78ec096 to
aad46c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131674.
Summary
When internal chunk boundaries are inconsistent (typically due to concurrent modification),
StringBuilder.ToString()previously threw anArgumentOutOfRangeExceptionwithchunkLengthas the parameter name.While the exception type is kept for compatibility, the message and parameter name are corrected. This PR updates the exception to use a clear, dedicated resource string indicating internal state corruption rather than a fictitious method parameter.
Changes
StringBuilder.ToString()to throwArgumentOutOfRangeExceptionwithnullparameter name and a proper descriptive message (SR.InvalidOperation_ConcurrentOperationsNotSupported).