Chrome upgrade PR should bump mac versions as well.#129974
Merged
ilonatommy merged 7 commits intoJun 29, 2026
Merged
Conversation
… mac to run on bump PRs and detect faulty versions.
ilonatommy
requested review from
a team,
akoeplinger,
jeffhandley and
maraf
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the WebAssembly “bump Chrome for testing” automation to include macOS, wires up a new browser_wasm_mac CI platform/Helix queue, and adds a macOS smoke-test leg that runs only when the bump PR updates Chrome versions.
Changes:
- Teach
UpdateChromeVersionsto handle macOS (props updates, env var export, V8 binary URL mapping) and to skip non-upgrade candidates. - Add macOS to the automated bump job inputs and PR title (OSIdentifiers/OSPrefixes + workflow env/title).
- Add
browser_wasm_macto the platform matrix + Helix queues, and gate the macOS smoke test leg on “Chrome version update” path changes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tasks/WasmBuildTasks/UpdateChromeVersions.cs | Adds macOS support to the Chrome/V8 updater and “no downgrade” gating. |
| eng/testing/bump-chrome-version.proj | Includes macOS in the automated bump task inputs. |
| eng/pipelines/runtime.yml | Adds a macOS WASM smoke-test leg gated to Chrome bump PRs. |
| eng/pipelines/libraries/helix-queues-setup.yml | Maps browser_wasm_mac to the macOS ARM64 Helix queue. |
| eng/pipelines/common/templates/wasm-library-tests.yml | Adds runOnlyOnChromeVersionUpdate parameter to control job condition. |
| eng/pipelines/common/platform-matrix.yml | Introduces browser_wasm_mac job setup via xplat-setup.yml. |
| .github/workflows/bump-chrome-version.yml | Updates bump PR title generation to include the macOS Chrome version. |
…rness to fix "session not created: cannot find Chrome binary".
akoeplinger
approved these changes
Jun 29, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
maraf
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1
In #124852 we added chrome for mac version to provisioning list. Since then the version was not updated because it's not added to platforms covered by automation.
Problem 2
In #129851 we manually upgraded v8 version. The next automated PR #129934 downgraded it.
Changes