Rm goto in HashCode Add byte span

[michaelnathanroberts]

Removed a goto in HashCode.cs and added a private function to avoid a bulky if statement and the goto antipatterns.

[AaronRobinsonMSFT]

@michaelnathanroberts This is a very odd change given the amount of reviewers and the description. I'm going to close this for now as reviewing this particular PR doesn't seem appropriate. If you'd like to submit a new one, please make it much more targeted and perhaps have additional details on what make the change beneficial in a measurable manner.

[michaelnathanroberts]

Hi @AaronRobinsonMSFT, I removed a goto in the Add function of System.HashCode. It is purely stylistic because gotos are generally considered an anti-pattern (see Djikstra's GOTO considered harmful). Please advise what other information I should include and who should I ask to review it?

[huoyaoyuan]

The PR contains many unrelated file permission and other changes. Please ensure you are using Git properly.

It is purely stylistic because gotos are generally considered an anti-pattern (see Djikstra's GOTO considered harmful).

This is not true. Goto is harmful when abused. It's necessary for advanced performance optimization. System.HashCode is a fundamental component and applicable for advanced optimization.

This PR will not be acceptable given its motivation.