Skip to content

[cDAC] Enumerate R2R hashmap pages into triage dumps for odd entry points #129931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-charlamb merged 6 commits into from
Jun 28, 2026
+7 −2
Merged

[cDAC] Enumerate R2R hashmap pages into triage dumps for odd entry points #129931

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f91d2db
[cDAC] Bail R2R MethodDesc lookup for odd entry points on AMD64/x86
max-charlamb Jun 27, 2026
ec96aae
[cDAC] Register IRuntimeInfo in ExecutionManager R2R unit tests
Jun 28, 2026
573842e
comment
Jun 28, 2026
ff55472
update based on comments
Jun 28, 2026
74d2ec6
Move R2R odd-entry-point bail to non-DAC builds; drop it from cDAC
Jun 28, 2026
8e5b6e8
Revert cDAC ReadyToRunJitManager to main (no change needed)
Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/coreclr/vm/readytoruninfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,9 +368,14 @@ PTR_MethodDesc ReadyToRunInfo::GetMethodDescForEntryPointInNativeImage(PCODE ent
}
CONTRACTL_END;

#if defined(TARGET_AMD64) || defined(TARGET_X86)
#if (defined(TARGET_AMD64) || defined(TARGET_X86)) && !defined(DACCESS_COMPILE)
// A normal method entry point is always 8 byte aligned, but a funclet can start at an odd address.
// Since PtrHashMap can't handle odd pointers, check for this case and return NULL.
// The map only contains true method entry points, so a lookup for an odd (funclet) address is
// always a miss. Skip the guaranteed-miss lookup as a performance optimization.
//
Comment thread
max-charlamb marked this conversation as resolved.
// This is intentionally limited to non-DAC builds. The DAC must perform the lookup so that the
// hashmap bucket pages it touches are enumerated into triage minidumps; otherwise a consumer
// (such as the cDAC) faults when it later probes those not-in-dump pages. See dotnet/diagnostics#5910.
if ((entryPoint & 0x1) != 0)
return NULL;
#endif
Expand Down