Skip to content

Fix IsKnownNonNull assert for SIMD base addresses #129788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 3 commits into from
Jun 24, 2026
Merged

Fix IsKnownNonNull assert for SIMD base addresses #129788

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c853a0
Fix IsKnownNonNull assert for SIMD base addresses (SVE gather/scatter)
EgorBo Jun 24, 2026
35a4775
Cache TypeOfVN, shorten comment
EgorBo Jun 24, 2026
97292d2
Update valuenum.cpp
EgorBo Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,7 +1619,13 @@ bool ValueNumStore::IsKnownNonNull(ValueNum vn)
return false;
}

assert((TypeOfVN(vn) == TYP_I_IMPL) || (TypeOfVN(vn) == TYP_REF) || (TypeOfVN(vn) == TYP_BYREF));
// Ignore corner cases like a SIMD value - SIMD could be a base address of an indirection
// (e.g. SVE GatherVector, a vector of addresses).
Comment thread
EgorBo marked this conversation as resolved.
var_types vnType = TypeOfVN(vn);
if ((vnType != TYP_I_IMPL) && (vnType != TYP_REF) && (vnType != TYP_BYREF))
{
return false;
}

target_ssize_t offset;
PeelOffsets(&vn, &offset);
Expand Down
Loading