Sync run.sh and run.cmd options with run.py - #125511
Sync run.sh and run.cmd options with run.py#125511jtschuster with Copilot wants to merge 5 commits into
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
- Fix bug in run.sh: passes '--tieringtest' to run.py but run.py expects '--tiering_test' - Add '--parallel=<type>' option to run.sh (was in run.cmd but missing from run.sh) - Add 'verbose' option to run.cmd (was in run.sh but missing from run.cmd) - Add 'limitedDumpGeneration' option to run.cmd (was in run.sh but missing from run.cmd) Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
|
@copilot make sure all the flags that are accepted are in the help menus too. |
…; fix empty description in run.sh Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Done in b79eb42:
|
|
@copilot Add the |
… comment Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Done in 2c43f5e — removed the "intentionally undocumented" comment and added |
| echo ' --interpreter : Runs the tests with the interpreter enabled' | ||
| echo ' --node : Runs the tests with NodeJS (wasm only)' | ||
| echo ' --limitedDumpGeneration : ' | ||
| echo ' --limitedDumpGeneration : Limits the number of core dumps generated for this test run' |
There was a problem hiding this comment.
@copilot Don't we need largeversionbubblecrossgen2tests here too? And I don't think Composite mode is in run.py, but is in the test runners via an environment variable. We should add it to run.py and run.sh and run.cmd.
There was a problem hiding this comment.
Done in 9f41b7c:
- Added
--runlargeversionbubblecrossgen2teststorun.sh(argument parsing, help menu, forwarding--run_crossgen2_tests+--large_version_bubbleto run.py) - Added
--compositetorun.py(setsCompositeBuildMode=1env var, matchinghelixpublishwitharcade.proj) - Added
--compositetorun.shandcompositetorun.cmd(both forward--compositeto run.py) - All three entries documented in their respective help menus as
(Experimental)
…to all scripts Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Description
run.shandrun.cmdwere missing several options accepted byrun.py, andrun.shhad a bug where it passed--tieringtesttorun.pywhich only recognizes--tiering_test(causing the argument to be silently ignored or fail). Additionally, several flags accepted by both scripts were missing from their help menus, one option was intentionally hidden, and Composite mode was only available via environment variable but not exposed through the scripts.run.sh--tieringtest→--tiering_testwhen forwarding torun.py--parallel=<type>option (none,collections,assemblies,all) — already present inrun.cmd, missing fromrun.sh--runlargeversionbubblecrossgen2tests— setsRunCrossGen2=1and forwards--large_version_bubbletorun.py; already inrun.cmd, missing fromrun.sh--composite— forwards--compositetorun.pyto enable Crossgen2 composite mode--limitedDumpGeneration(previously had an empty description)run.cmdverbose— passes--verbosetorun.py; already inrun.sh, missing fromrun.cmdlimitedDumpGeneration— passes--limited_core_dumpstorun.py; already inrun.sh, missing fromrun.cmdcomposite— passes--compositetorun.pyto enable Crossgen2 composite modetieringtest,runnativeaottests,runlargeversionbubblecrossgen2tests, andcompositeto the help menu — they were accepted by the argument parser but not documentedverbose,limitedDumpGeneration,interpreter, andnodeentries in the help sectionrunlargeversionbubblecrossgen2tests; option is now documented as experimentalrun.py--compositeargument — setsCompositeBuildMode=1environment variable, matching the pattern used inhelixpublishwitharcade.projfor Helix test runsChanges
src/tests/run.shsrc/tests/run.cmdsrc/tests/run.pyTesting
Shell script syntax verified (
bash -n). Python syntax verified (py_compile). No build artifacts affected.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.