-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/10.0] Add support for Visual Studio 2026 CMake generator for gen-buildsys.cmd
#121889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the Visual Studio 2026 CMake generator in the native build system configuration script. The change enables the build system to recognize and use Visual Studio 18 (2026) when generating build files.
- Adds a conditional check for VS version 18.0 to set the CMake generator to "Visual Studio 18 2026"
- Follows the existing pattern established for VS 2022 (version 17.0)
- Placed appropriately before the VS 2022 check to handle newer versions first
gen-buildsys.cmdVisual Studio 2026 CMake generator for gen-buildsys.cmd
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Visual Studio 2026 CMake generator for gen-buildsys.cmdVisual Studio 2026 CMake generator for gen-buildsys.cmd
|
This was fixed in main by #120580 . I see you have submitted your change against release/10.0 branch. We require justification for all backport to release branches. Could you share why you would like to see this change backported to release/10.0? |
|
Ah, sorry, I haven't seen that this is already fixed in |
Backport of #120580 to release/10.0
Customer Impact
The repo cmake msbuild generator is missing support for VS 2026 in release/10.0 branch. It makes it hard to work with the repo C/C++ code in VS 2026.
Regression
Testing
Verified that gen-buildsys.cmd selects the Visual Studio 18 2026 generator when %_VSVersion% is 18.0.
Risk
Low. No impact to skipping binaries.
Adds support for the
Visual Studio 18 2026CMake generator ineng/native/gen-buildsys.cmd.%_VSVersion% == "18.0"similarly to the existing Visual Studio 2022 case.Testing:
gen-buildsys.cmdselects theVisual Studio 18 2026generator when%_VSVersion%is18.0.