Skip to content

Conversation

@iikuzmychov
Copy link

@iikuzmychov iikuzmychov commented Nov 21, 2025

Backport of #120580 to release/10.0

Customer Impact

  • Customer reported
  • Found internally

The repo cmake msbuild generator is missing support for VS 2026 in release/10.0 branch. It makes it hard to work with the repo C/C++ code in VS 2026.

Regression

  • Yes
  • No

Testing

Verified that gen-buildsys.cmd selects the Visual Studio 18 2026 generator when %_VSVersion% is 18.0.

Risk

Low. No impact to skipping binaries.


Adds support for the Visual Studio 18 2026 CMake generator in eng/native/gen-buildsys.cmd.

  • Handles %_VSVersion% == "18.0" similarly to the existing Visual Studio 2022 case.
  • Does not change behavior for other Visual Studio versions.

Testing:

  • Verified that gen-buildsys.cmd selects the Visual Studio 18 2026 generator when %_VSVersion% is 18.0.

Copilot AI review requested due to automatic review settings November 21, 2025 21:55
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 21, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 21, 2025
Copilot finished reviewing on behalf of iikuzmychov November 21, 2025 21:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the Visual Studio 2026 CMake generator in the native build system configuration script. The change enables the build system to recognize and use Visual Studio 18 (2026) when generating build files.

  • Adds a conditional check for VS version 18.0 to set the CMake generator to "Visual Studio 18 2026"
  • Follows the existing pattern established for VS 2022 (version 17.0)
  • Placed appropriately before the VS 2022 check to handle newer versions first

@iikuzmychov iikuzmychov changed the title Add Visual Studio 2026 CMake generator support for gen-buildsys.cmd Add support for Visual Studio 2026 CMake generator for gen-buildsys.cmd Nov 21, 2025
@vcsjones vcsjones added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 21, 2025
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas changed the title Add support for Visual Studio 2026 CMake generator for gen-buildsys.cmd [release/10.0] Add support for Visual Studio 2026 CMake generator for gen-buildsys.cmd Nov 22, 2025
@jkotas
Copy link
Member

jkotas commented Nov 22, 2025

This was fixed in main by #120580 . I see you have submitted your change against release/10.0 branch. We require justification for all backport to release branches.

Could you share why you would like to see this change backported to release/10.0?

@iikuzmychov
Copy link
Author

iikuzmychov commented Nov 22, 2025

Ah, sorry, I haven't seen that this is already fixed in main brach. Basically why I created this PR is because I wanted to debug last stable version from release/10.0. I've tried to run .\build.cmd -vs CoreClr.sln or smth like this and got an error. During investigation I found that the issue is an absent condition within this .bat. I found no fixes for this within this branch so I decided to make a PR

@jkotas jkotas added the Servicing-consider Issue for next servicing release review label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member Servicing-consider Issue for next servicing release review

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants