Backport PR #121603: Fix RoslynAnalyzer crash on indexer property parameters #121861
+82
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #121603 to release/10.0. Fixes #121546.
The RoslynAnalyzer crashes when analyzing indexer property parameter initializers because it assumes all parameters belong to methods, but Roslyn provides operation blocks for property indexer parameters that don't have a direct IL equivalent.
Changes
TrimAnalysisVisitor.cs: Guard against null
parameterMethodinGetParameterTargetValue. ReturnsTopValuefor parameters not owned by methods (e.g., indexer parameter initializers), preventing crashes while preserving correct analysis for method parameters.PropertyDataFlow.cs: Add test coverage for annotated indexer parameters and indexers with default arguments to verify the analyzer handles these cases without crashing.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.